internal: (studio) add telemetry around time it takes to download the bundle and initialize studio fully #31834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bundle and initialize studio fully
There was a problem hiding this comment.
Pull Request Overview
This PR introduces telemetry instrumentation to measure the performance of the studio bundle download and initialization process. Key changes include:
- Adding telemetry marks and measures across studio initialization and bundle lifecycle events.
- Integrating telemetry reporting with Honeycomb via TelemetryReporter.
- Expanding test coverage for telemetry components and ensuring proper behavior during error handling.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/server/test/unit/project_spec.js | Added tests for telemetry marks in studio initialization flows. |
| packages/server/test/unit/cloud/studio/telemetry/TelemetryReporter_spec.ts | Implemented unit tests for TelemetryReporter functionality and error handling. |
| packages/server/test/unit/cloud/studio/telemetry/TelemetryManager_spec.ts | Added tests verifying marking, measuring, and clearing telemetry data. |
| packages/server/test/unit/cloud/studio/StudioLifecycleManager_spec.ts | Extended telemetry-related assertions in studio lifecycle management tests. |
| packages/server/lib/project-base.ts | Integrated telemetry marking and reporting in the onStudioInit callback. |
| packages/server/lib/cloud/studio/telemetry/* | New telemetry constants, reporters, and a telemetry manager implementation. |
| packages/server/lib/cloud/studio/StudioLifecycleManager.ts | Instrumented studio lifecycle events with telemetry marks and telemetry reporting. |
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/internal/add-telemetry-for-studio-download
|
| Run status |
|
| Run duration | 19m 23s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32182
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.56%
|
|
|---|---|
|
Untested elements
|
191
|
|
Tested elements
|
164
|
Accessibility
92.73%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
696
|
mschile
approved these changes
Jun 6, 2025
ryanthemanuel
deleted the
ryanm/internal/add-telemetry-for-studio-download
branch
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We need to be able to track on how long it takes to download the studio bundle and initialize it fully. This PR will send those results to honeycomb.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?